From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 2 Dec 2020 00:47:14 +0000 (+1300)
Subject: kcc: use py3 compatible sort in rarely visited branch
X-Git-Tag: tevent-0.11.0~1468
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c4f338b7e4ef068b516e80165cf5032815b0bb2d;p=thirdparty%2Fsamba.git

kcc: use py3 compatible sort in rarely visited branch

This won't have worked for some time, but nobody has complained,
because nobody uses DS_NTDSSETTINGS_OPT_IS_RAND_BH_SELECTION_DISABLED

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/python/samba/kcc/__init__.py b/python/samba/kcc/__init__.py
index 73cdc9f1ef0..c87cc14fcff 100644
--- a/python/samba/kcc/__init__.py
+++ b/python/samba/kcc/__init__.py
@@ -21,7 +21,7 @@
 
 import random
 import uuid
-
+from functools import cmp_to_key
 import itertools
 from samba import unix2nttime, nttime2unix
 from samba import ldb, dsdb, drs_utils
@@ -1285,7 +1285,7 @@ class KCC(object):
         # ELSE
         #    SORT bhs in a random order
         if site.is_random_bridgehead_disabled():
-            bhs.sort(sort_dsa_by_gc_and_guid)
+            bhs.sort(key=cmp_to_key(sort_dsa_by_gc_and_guid))
         else:
             random.shuffle(bhs)
         debug.DEBUG_YELLOW(bhs)