From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 10 Nov 2017 20:55:22 +0000 (-0500)
Subject: dereference after NULL.  CID #142093
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c4fd0dfa74724208c61ad533513da34ea200f8ec;p=thirdparty%2Ffreeradius-server.git

dereference after NULL.  CID #142093
---

diff --git a/src/main/xlat_eval.c b/src/main/xlat_eval.c
index fe0e13b1234..518473185a2 100644
--- a/src/main/xlat_eval.c
+++ b/src/main/xlat_eval.c
@@ -476,8 +476,8 @@ static rlm_rcode_t xlat_eval_pair(TALLOC_CTX *ctx, fr_cursor_t *out, REQUEST *re
 		 */
 		vp = fr_cursor_current(&cursor);			/* NULLness checked above */
 		value = fr_value_box_alloc(ctx, vp->data.type, vp->da, vp->data.tainted);
-		fr_value_box_copy_shallow(value, value, &vp->data);	/* Also dups taint */
 		if (!value) goto oom;
+		fr_value_box_copy_shallow(value, value, &vp->data);	/* Also dups taint */
 		fr_cursor_append(out, value);
 		return RLM_MODULE_UPDATED;
 	}