From: James Coglan <james@neighbourhood.ie>
Date: Fri, 31 May 2024 08:37:00 +0000 (+0100)
Subject: resolved: tests for dns_question_is_valid_for_query()
X-Git-Tag: v257-rc1~842^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c530740e201e0af1f5b5eaca61018c0e32163b03;p=thirdparty%2Fsystemd.git

resolved: tests for dns_question_is_valid_for_query()
---

diff --git a/src/resolve/test-dns-question.c b/src/resolve/test-dns-question.c
index 3cbb3a99ee6..62156ac6e27 100644
--- a/src/resolve/test-dns-question.c
+++ b/src/resolve/test-dns-question.c
@@ -394,4 +394,84 @@ TEST(dns_question_matches_cname_or_dname_all_must_redirect) {
         ASSERT_FALSE(dns_question_matches_cname_or_dname(question, rr, NULL));
 }
 
+/* ================================================================
+ * dns_question_is_valid_for_query()
+ * ================================================================ */
+
+TEST(dns_question_is_valid_for_query_empty) {
+        _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL;
+
+        question = dns_question_new(0);
+        ASSERT_NOT_NULL(question);
+        ASSERT_FALSE(dns_question_is_valid_for_query(question));
+}
+
+TEST(dns_question_is_valid_for_query_single) {
+        _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL;
+        _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL;
+
+        question = dns_question_new(1);
+        ASSERT_NOT_NULL(question);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        dns_question_add(question, key, 0);
+
+        ASSERT_TRUE(dns_question_is_valid_for_query(question));
+}
+
+TEST(dns_question_is_valid_for_query_invalid_type) {
+        _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL;
+        _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL;
+
+        question = dns_question_new(1);
+        ASSERT_NOT_NULL(question);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_OPT, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        dns_question_add(question, key, 0);
+
+        ASSERT_FALSE(dns_question_is_valid_for_query(question));
+}
+
+TEST(dns_question_is_valid_for_query_multi_same_name) {
+        _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL;
+        DnsResourceKey *key = NULL;
+
+        question = dns_question_new(2);
+        ASSERT_NOT_NULL(question);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        dns_question_add(question, key, 0);
+        dns_resource_key_unref(key);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.EXAMPLE.com");
+        ASSERT_NOT_NULL(key);
+        dns_question_add(question, key, 0);
+        dns_resource_key_unref(key);
+
+        ASSERT_TRUE(dns_question_is_valid_for_query(question));
+}
+
+TEST(dns_question_is_valid_for_query_multi_different_names) {
+        _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL;
+        DnsResourceKey *key = NULL;
+
+        question = dns_question_new(2);
+        ASSERT_NOT_NULL(question);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        dns_question_add(question, key, 0);
+        dns_resource_key_unref(key);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.example.org");
+        ASSERT_NOT_NULL(key);
+        dns_question_add(question, key, 0);
+        dns_resource_key_unref(key);
+
+        ASSERT_FALSE(dns_question_is_valid_for_query(question));
+}
+
 DEFINE_TEST_MAIN(LOG_DEBUG);