From: Cornelia Huck <cornelia.huck@de.ibm.com>
Date: Thu, 16 Oct 2008 22:05:05 +0000 (+0000)
Subject: Driver core: Fix cleanup in device_create_vargs().
X-Git-Tag: v2.6.27.3~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c552cad06920b6dc20bb0b41bbb37b60f194e46a;p=thirdparty%2Fkernel%2Fstable.git

Driver core: Fix cleanup in device_create_vargs().

commit 286661b3777897220ecfcd774bccc68a34667f39 upstream

If device_register() in device_create_vargs() fails, the device
must be cleaned up with put_device() (which is also fine on NULL)
instead of kfree().

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/base/core.c b/drivers/base/core.c
index d021c98605b3a..94aee9d68a03b 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1243,7 +1243,7 @@ struct device *device_create_vargs(struct class *class, struct device *parent,
 	return dev;
 
 error:
-	kfree(dev);
+	put_device(dev);
 	return ERR_PTR(retval);
 }
 EXPORT_SYMBOL_GPL(device_create_vargs);