From: Günther Deschner <gd@samba.org>
Date: Thu, 8 May 2008 12:24:46 +0000 (+0200)
Subject: dsgetdcname: the forest name should never be empty.
X-Git-Tag: samba-4.0.0alpha6~801^2~1442
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c58ab8f3b251f9fbf79fc8a528717e0756c02a76;p=thirdparty%2Fsamba.git

dsgetdcname: the forest name should never be empty.

Guenther
(This used to be commit 2c0a96f1e5fc065fdbeb5671cfa693009321dde8)
---

diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
index 2c8f42399f9..8021f8f054d 100644
--- a/source3/libsmb/dsgetdcname.c
+++ b/source3/libsmb/dsgetdcname.c
@@ -785,7 +785,7 @@ static NTSTATUS make_domain_controller_info(TALLOC_CTX *mem_ctx,
 		NT_STATUS_HAVE_NO_MEMORY(info->domain_name);
 	}
 
-	if (forest_name) {
+	if (forest_name && *forest_name) {
 		info->forest_name = talloc_strdup(mem_ctx, forest_name);
 		NT_STATUS_HAVE_NO_MEMORY(info->forest_name);
 		flags |= DS_DNS_FOREST;