From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 2 Aug 2023 22:49:51 +0000 (+1200)
Subject: s4:auth: Check return value of talloc_reference()
X-Git-Tag: tevent-0.16.0~1120
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c590d8d3a38e136cdb4d59985a3db420b80ae7d8;p=thirdparty%2Fsamba.git

s4:auth: Check return value of talloc_reference()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/auth/session.c b/source4/auth/session.c
index a240cdb2e22..de7522bc416 100644
--- a/source4/auth/session.c
+++ b/source4/auth/session.c
@@ -220,6 +220,10 @@ _PUBLIC_ NTSTATUS auth_generate_session_info(TALLOC_CTX *mem_ctx,
 	}
 
 	session_info->info = talloc_reference(session_info, user_info_dc->info);
+	if (session_info->info == NULL) {
+		TALLOC_FREE(tmp_ctx);
+		return NT_STATUS_NO_MEMORY;
+	}
 
 	session_info->torture = talloc_zero(session_info, struct auth_user_info_torture);
 	if (session_info->torture == NULL) {