From: Nicholas Nethercote <njn@valgrind.org>
Date: Wed, 1 Jul 2009 05:05:38 +0000 (+0000)
Subject: Add a comment.
X-Git-Tag: svn/VALGRIND_3_5_0~455
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c5fba359610bd457905ed431da90ba23bae2bbec;p=thirdparty%2Fvalgrind.git

Add a comment.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10391
---

diff --git a/massif/ms_main.c b/massif/ms_main.c
index 4b64bbd220..c54fc3cf1d 100644
--- a/massif/ms_main.c
+++ b/massif/ms_main.c
@@ -303,6 +303,16 @@ static void init_alloc_fns(void)
    // always anyway, because even if they're overloaded, it would be a
    // prodigiously stupid overloading that caused them to not allocate
    // memory.
+   //
+   // XXX: because we don't look at the first stack entry (unless it's a
+   // custom allocation) there's not much point to having all these alloc
+   // functions here -- they should never appear anywhere (I think?) other
+   // than the top stack entry.  The only exceptions are those that in
+   // vg_replace_malloc.c are partly or fully implemented in terms of another
+   // alloc function: realloc (which uses malloc);  valloc,
+   // malloc_zone_valloc, posix_memalign and memalign_common (which use
+   // memalign).
+   //
    DO("malloc"                                              );
    DO("__builtin_new"                                       );
    DO("operator new(unsigned)"                              );