From: Sunil Khatri <sunil.khatri@amd.com>
Date: Tue, 28 Oct 2025 12:09:27 +0000 (+0530)
Subject: drm/amdgpu: caller should make sure not to double free
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c6526cc6f887c710bab21ee934035a2c9ffb8c4b;p=thirdparty%2Fkernel%2Flinux.git

drm/amdgpu: caller should make sure not to double free

Remove the NULL check from amdgpu_hmm_range_free for hmm_pfns
as caller is responsible not to call amdgpu_hmm_range_free
more than once.

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_hmm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_hmm.c
index 518ca3f4db2bc..90d26d820bac0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_hmm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_hmm.c
@@ -287,9 +287,7 @@ void amdgpu_hmm_range_free(struct amdgpu_hmm_range *range)
 	if (!range)
 		return;
 
-	if (range->hmm_range.hmm_pfns)
-		kvfree(range->hmm_range.hmm_pfns);
-
+	kvfree(range->hmm_range.hmm_pfns);
 	amdgpu_bo_unref(&range->bo);
 	kfree(range);
 }