From: Simon Marchi Date: Mon, 9 Mar 2026 18:31:44 +0000 (-0400) Subject: gdb: change gdbarch_adjust_dwarf2_line parameter to bool X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c68cf3027014baba74cc481bdc2a7482a5925f28;p=thirdparty%2Fbinutils-gdb.git gdb: change gdbarch_adjust_dwarf2_line parameter to bool Straightforward int to bool conversion. Change-Id: I40b69ed4da58a375e5359d58768e58ad5afdf3be Approved-By: Tom Tromey --- diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c index 98732420fe2..8de7655e638 100644 --- a/gdb/arch-utils.c +++ b/gdb/arch-utils.c @@ -232,7 +232,7 @@ default_adjust_dwarf2_addr (CORE_ADDR pc) /* See arch-utils.h. */ CORE_ADDR -default_adjust_dwarf2_line (CORE_ADDR addr, int rel) +default_adjust_dwarf2_line (CORE_ADDR addr, bool rel) { return addr; } diff --git a/gdb/arch-utils.h b/gdb/arch-utils.h index a898a3b1ad2..d5772575c7a 100644 --- a/gdb/arch-utils.h +++ b/gdb/arch-utils.h @@ -193,7 +193,7 @@ CORE_ADDR default_adjust_dwarf2_addr (CORE_ADDR pc); /* Do nothing default implementation of gdbarch_adjust_dwarf2_line. */ -CORE_ADDR default_adjust_dwarf2_line (CORE_ADDR addr, int rel); +CORE_ADDR default_adjust_dwarf2_line (CORE_ADDR addr, bool rel); /* Default DWARF vendor CFI handler. */ diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c index e6e9235f7bc..b9da1b4799f 100644 --- a/gdb/dwarf2/line-program.c +++ b/gdb/dwarf2/line-program.c @@ -519,7 +519,7 @@ lnp_state_machine::lnp_state_machine (struct dwarf2_cu *cu, gdbarch *arch) chance to adjust it and also record it in case it needs it. This is currently used by MIPS code, cf. `mips_adjust_dwarf2_line'. */ - m_address ((unrelocated_addr) gdbarch_adjust_dwarf2_line (arch, 0, 0)), + m_address ((unrelocated_addr) gdbarch_adjust_dwarf2_line (arch, 0, false)), m_flags (m_cu->line_header->default_is_stmt ? LEF_IS_STMT : (linetable_entry_flags) 0), m_last_address (m_address) diff --git a/gdb/gdbarch-gen.c b/gdb/gdbarch-gen.c index 5c524d58cc3..ddf982ebcf4 100644 --- a/gdb/gdbarch-gen.c +++ b/gdb/gdbarch-gen.c @@ -3445,7 +3445,7 @@ set_gdbarch_adjust_dwarf2_addr (struct gdbarch *gdbarch, } CORE_ADDR -gdbarch_adjust_dwarf2_line (struct gdbarch *gdbarch, CORE_ADDR addr, int rel) +gdbarch_adjust_dwarf2_line (struct gdbarch *gdbarch, CORE_ADDR addr, bool rel) { gdb_assert (gdbarch != nullptr); gdb_assert (gdbarch->adjust_dwarf2_line != nullptr); diff --git a/gdb/gdbarch-gen.h b/gdb/gdbarch-gen.h index 0c15a86765a..b6ec669ee2b 100644 --- a/gdb/gdbarch-gen.h +++ b/gdb/gdbarch-gen.h @@ -883,8 +883,8 @@ void set_gdbarch_adjust_dwarf2_addr (struct gdbarch *gdbarch, gdbarch_adjust_dwa in turn ensures breakpoint addresses are correctly matched against the stop PC. */ -using gdbarch_adjust_dwarf2_line_ftype = CORE_ADDR (CORE_ADDR addr, int rel); -CORE_ADDR gdbarch_adjust_dwarf2_line (struct gdbarch *gdbarch, CORE_ADDR addr, int rel); +using gdbarch_adjust_dwarf2_line_ftype = CORE_ADDR (CORE_ADDR addr, bool rel); +CORE_ADDR gdbarch_adjust_dwarf2_line (struct gdbarch *gdbarch, CORE_ADDR addr, bool rel); void set_gdbarch_adjust_dwarf2_line (struct gdbarch *gdbarch, gdbarch_adjust_dwarf2_line_ftype *adjust_dwarf2_line); bool gdbarch_cannot_step_breakpoint (struct gdbarch *gdbarch); diff --git a/gdb/gdbarch_components.py b/gdb/gdbarch_components.py index b1cff8c2b69..424558d6ae0 100644 --- a/gdb/gdbarch_components.py +++ b/gdb/gdbarch_components.py @@ -1517,7 +1517,7 @@ stop PC. """, type="CORE_ADDR", name="adjust_dwarf2_line", - params=[("CORE_ADDR", "addr"), ("int", "rel")], + params=[("CORE_ADDR", "addr"), ("bool", "rel")], predefault="default_adjust_dwarf2_line", invalid=False, ) diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 161c94569a8..3ecf5283a90 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -1343,7 +1343,7 @@ mips_adjust_dwarf2_addr (CORE_ADDR pc) that sets PC to 0 and ADJ_PC accordingly, usually 0 as well. */ static CORE_ADDR -mips_adjust_dwarf2_line (CORE_ADDR addr, int rel) +mips_adjust_dwarf2_line (CORE_ADDR addr, bool rel) { static CORE_ADDR adj_pc; static CORE_ADDR pc;