From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 1 Feb 2016 18:12:58 +0000 (-0500)
Subject: Bitwise negate is ~, not !.
X-Git-Tag: tor-0.2.8.1-alpha~22
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c6fa55d2da728ab5abb8be82eba4c903c452516e;p=thirdparty%2Ftor.git

Bitwise negate is ~, not !.

Spotted by coverity; bug in tests only, not in any released Tor.

This is CID 1351128
---

diff --git a/src/test/test_routerlist.c b/src/test/test_routerlist.c
index 090a60766c..8c4254ccd7 100644
--- a/src/test/test_routerlist.c
+++ b/src/test/test_routerlist.c
@@ -311,7 +311,7 @@ test_router_pick_directory_server_impl(void *arg)
   node_router3->rs->last_dir_503_at = 0;
 
   /* Set a Fascist firewall */
-  flags &= ! PDS_IGNORE_FASCISTFIREWALL;
+  flags &= ~ PDS_IGNORE_FASCISTFIREWALL;
   policy_line = tor_malloc_zero(sizeof(config_line_t));
   policy_line->key = tor_strdup("ReachableORAddresses");
   policy_line->value = tor_strdup("accept *:442, reject *:*");