From: Micah Elizabeth Scott <beth@torproject.org>
Date: Thu, 11 May 2023 18:10:15 +0000 (-0700)
Subject: equix: avoid a coverity warning in hashx_alloc()
X-Git-Tag: tor-0.4.8.1-alpha~29^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c71b6a14a391769261a08e96d0a1d90b5d1c9e11;p=thirdparty%2Ftor.git

equix: avoid a coverity warning in hashx_alloc()

This addresses one of the warnings in issue #40792. As far as I can tell
this is a false positive, since the use of "ctx->type" in hashx_free()
can only be hit after the unioned code/program pointer is non-NULL. It's
no big deal to zero this value explicitly to silence the warning though.

Signed-off-by: Micah Elizabeth Scott <beth@torproject.org>
---

diff --git a/src/ext/equix/hashx/src/context.c b/src/ext/equix/hashx/src/context.c
index de2144d46c..8548fb7ffa 100644
--- a/src/ext/equix/hashx/src/context.c
+++ b/src/ext/equix/hashx/src/context.c
@@ -41,6 +41,7 @@ hashx_ctx* hashx_alloc(hashx_type type) {
 		goto failure;
 	}
 	ctx->code = NULL;
+	ctx->type = 0;
 	if (type & HASHX_COMPILED) {
 		if (!hashx_compiler_init(ctx)) {
 			goto failure;