From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Wed, 26 Feb 2025 21:31:35 +0000 (+0100)
Subject: exec-invoke: Fix unshare() error handling
X-Git-Tag: v258-rc1~1234^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c78b06b1d23b95e4ea5f507a719bded6a2737581;p=thirdparty%2Fsystemd.git

exec-invoke: Fix unshare() error handling

Follow up for cd58b5a13537fc89b669ff9232ba2206214c9fa1
---

diff --git a/src/core/exec-invoke.c b/src/core/exec-invoke.c
index 2cfff50afc1..6929dc1c154 100644
--- a/src/core/exec-invoke.c
+++ b/src/core/exec-invoke.c
@@ -5182,10 +5182,9 @@ int exec_invoke(
         }
 
         if (needs_sandboxing && exec_needs_cgroup_namespace(context, params)) {
-                r = unshare(CLONE_NEWCGROUP);
-                if (r < 0) {
+                if (unshare(CLONE_NEWCGROUP) < 0) {
                         *exit_status = EXIT_NAMESPACE;
-                        return log_exec_error_errno(context, params, r, "Failed to set up cgroup namespacing: %m");
+                        return log_exec_error_errno(context, params, errno, "Failed to set up cgroup namespacing: %m");
                 }
         }