From: cypherpunks <cypherpunks@torproject.org>
Date: Wed, 28 Jun 2017 12:35:01 +0000 (+0000)
Subject: Use the proper syscall in sandbox error messages
X-Git-Tag: tor-0.3.2.1-alpha~269
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c79e2863866ff4730fb3892d6cba3cf40e15077e;p=thirdparty%2Ftor.git

Use the proper syscall in sandbox error messages

Fixes #22750.
---

diff --git a/changes/ticket22750 b/changes/ticket22750
new file mode 100644
index 0000000000..6bc1fb2639
--- /dev/null
+++ b/changes/ticket22750
@@ -0,0 +1,3 @@
+  o Minor bugfixes (logging, sandbox):
+    - Use the correct system call in sandbox error messages. Fixes bug
+      22750; bugfix on 0.2.5.1-alpha.
diff --git a/src/common/sandbox.c b/src/common/sandbox.c
index 52caa4fcc6..fb57902593 100644
--- a/src/common/sandbox.c
+++ b/src/common/sandbox.c
@@ -480,7 +480,7 @@ sb_chmod(scmp_filter_ctx ctx, sandbox_cfg_t *filter)
       rc = seccomp_rule_add_1(ctx, SCMP_ACT_ALLOW, SCMP_SYS(chmod),
             SCMP_CMP_STR(0, SCMP_CMP_EQ, param->value));
       if (rc != 0) {
-        log_err(LD_BUG,"(Sandbox) failed to add open syscall, received "
+        log_err(LD_BUG,"(Sandbox) failed to add chmod syscall, received "
             "libseccomp error %d", rc);
         return rc;
       }
@@ -505,7 +505,7 @@ sb_chown(scmp_filter_ctx ctx, sandbox_cfg_t *filter)
       rc = seccomp_rule_add_1(ctx, SCMP_ACT_ALLOW, SCMP_SYS(chown),
             SCMP_CMP_STR(0, SCMP_CMP_EQ, param->value));
       if (rc != 0) {
-        log_err(LD_BUG,"(Sandbox) failed to add open syscall, received "
+        log_err(LD_BUG,"(Sandbox) failed to add chown syscall, received "
             "libseccomp error %d", rc);
         return rc;
       }
@@ -1037,7 +1037,7 @@ sb_stat64(scmp_filter_ctx ctx, sandbox_cfg_t *filter)
       rc = seccomp_rule_add_1(ctx, SCMP_ACT_ALLOW, SCMP_SYS(stat64),
           SCMP_CMP_STR(0, SCMP_CMP_EQ, param->value));
       if (rc != 0) {
-        log_err(LD_BUG,"(Sandbox) failed to add open syscall, received "
+        log_err(LD_BUG,"(Sandbox) failed to add stat64 syscall, received "
             "libseccomp  error %d", rc);
         return rc;
       }