From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Fri, 17 Apr 2026 13:51:40 +0000 (+0200)
Subject: namespace: don't log misleading error in the r > 0 path
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c859d41232b3bcff9f9b01f1281c1b202f15d0b2;p=thirdparty%2Fsystemd.git

namespace: don't log misleading error in the r > 0 path

fd_is_fs_type() returns < 0 for errors, 0 for false, and > 0 for true, so
in the r > branch we'd most likely report EPERM together with the error
message which is misleading.
---

diff --git a/src/core/namespace.c b/src/core/namespace.c
index ff4592b8b90..1412ccce8bb 100644
--- a/src/core/namespace.c
+++ b/src/core/namespace.c
@@ -3662,7 +3662,7 @@ static int unpeel_get_fd(const char *mount_path, int *ret_fd) {
                         _exit(EXIT_FAILURE);
                 }
                 if (r > 0) {
-                        log_debug_errno(r, "'%s' is still an overlay after opening mount tree: %m", mount_path);
+                        log_debug("'%s' is still an overlay after opening mount tree", mount_path);
                         _exit(EXIT_FAILURE);
                 }