From: Michal 'vorner' Vaner <michal.vaner@nic.cz>
Date: Mon, 18 Feb 2013 10:23:08 +0000 (+0100)
Subject: [2676] Note why Cmdctl is not converted.
X-Git-Tag: bind10-1.1.0beta1-release~83^2~20
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c8870e86d867789bf2e8dedf6f5e960dc47faaee;p=thirdparty%2Fkea.git

[2676] Note why Cmdctl is not converted.

Similar to previous commit, there's a hack in cmdctl that doesn't allow
it now.
---

diff --git a/src/bin/cmdctl/cmdctl.py.in b/src/bin/cmdctl/cmdctl.py.in
index 15a41ecc6e..646801695e 100755
--- a/src/bin/cmdctl/cmdctl.py.in
+++ b/src/bin/cmdctl/cmdctl.py.in
@@ -429,8 +429,13 @@ class CommandControl():
             # Process the command sent to cmdctl directly.
             answer = self.command_handler(command_name, params)
         else:
+            # FIXME: Due to the fact that we use a separate session
+            # from the module one (due to threads and blocking), and
+            # because the plain cc session does not have the high-level
+            # rpc-call method, we use the low-level way and create the
+            # command ourself.
             msg = ccsession.create_command(command_name, params)
-            seq = self._cc.group_sendmsg(msg, module_name)
+            seq = self._cc.group_sendmsg(msg, module_name, want_answer=True)
             logger.debug(DBG_CMDCTL_MESSAGING, CMDCTL_COMMAND_SENT,
                          command_name, module_name)
             #TODO, it may be blocked, msqg need to add a new interface waiting in timeout.