From: Volker Lendecke Date: Sat, 3 Mar 2012 16:02:01 +0000 (+0100) Subject: s3: Fix a bogus if (client_len < 0) X-Git-Tag: tdb-1.2.10~435 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c887cb6852ce6ec669f87c282aaaad55267c6d3e;p=thirdparty%2Fsamba.git s3: Fix a bogus if (client_len < 0) On some platforms socklen_t might be unsigned, so comparing for <0 always returns true. Also, tsocket_address_bsd_sockaddr returns ssize_t. Autobuild-User: Volker Lendecke Autobuild-Date: Sat Mar 3 23:38:31 CET 2012 on sn-devel-104 --- diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index ed5edcc0bac..f66bea8197c 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -2677,7 +2677,7 @@ WERROR _spoolss_RemoteFindFirstPrinterChangeNotifyEx(struct pipes_struct *p, int snum = -1; struct spoolss_NotifyOption *option = r->in.notify_options; struct sockaddr_storage client_ss; - socklen_t client_len; + ssize_t client_len; /* store the notify value in the printer struct */