From: Joakim Antman <antmanj@gmail.com>
Date: Wed, 19 Oct 2022 16:12:39 +0000 (+0300)
Subject: Fix parameter names for RSA private key example
X-Git-Tag: openssl-3.2.0-alpha1~1827
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c8c678e7d91ca2cea41c6c574cf7656a9404646f;p=thirdparty%2Fopenssl.git

Fix parameter names for RSA private key example

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19443)
---

diff --git a/doc/man3/OSSL_PARAM_BLD.pod b/doc/man3/OSSL_PARAM_BLD.pod
index 36182be0474..639f7bb5953 100644
--- a/doc/man3/OSSL_PARAM_BLD.pod
+++ b/doc/man3/OSSL_PARAM_BLD.pod
@@ -147,10 +147,12 @@ To pass signed B<BIGNUM>s, use OSSL_PARAM_BLD_push_signed_BN().
 Both examples creating an OSSL_PARAM array that contains an RSA key.
 For both, the predefined key variables are:
 
-    BIGNUM *p, *q;  /* both prime */
-    BIGNUM *n;      /* = p * q */
-    unsigned int e; /* exponent, usually 65537 */
-    BIGNUM *d;      /* e^-1 */
+    BIGNUM *n;           /* modulus */
+    unsigned int e;      /* public exponent */
+    BIGNUM *d;           /* private exponent */
+    BIGNUM *p, *q;       /* first two prime factors */
+    BIGNUM *dmp1, *dmq1; /* first two CRT exponents */
+    BIGNUM *iqmp;        /* first CRT coefficient */
 
 =head2 Example 1
 
@@ -161,11 +163,14 @@ private key.
     OSSL_PARAM *params = NULL;
 
     if (bld == NULL
-        || !OSSL_PARAM_BLD_push_BN(bld, "p", p)
-        || !OSSL_PARAM_BLD_push_BN(bld, "q", q)
-        || !OSSL_PARAM_BLD_push_uint(bld, "e", e)
         || !OSSL_PARAM_BLD_push_BN(bld, "n", n)
+        || !OSSL_PARAM_BLD_push_uint(bld, "e", e)
         || !OSSL_PARAM_BLD_push_BN(bld, "d", d)
+        || !OSSL_PARAM_BLD_push_BN(bld, "rsa-factor1", p)
+        || !OSSL_PARAM_BLD_push_BN(bld, "rsa-factor2", q)
+        || !OSSL_PARAM_BLD_push_BN(bld, "rsa-exponent1", dmp1)
+        || !OSSL_PARAM_BLD_push_BN(bld, "rsa-exponent2", dmq1)
+        || !OSSL_PARAM_BLD_push_BN(bld, "rsa-coefficient1", iqmp)
         || (params = OSSL_PARAM_BLD_to_param(bld)) == NULL)
         goto err;
     OSSL_PARAM_BLD_free(bld);
@@ -183,7 +188,7 @@ public key.
 
     if (nld == NULL
         || !OSSL_PARAM_BLD_push_BN(bld, "n", n)
-        || !OSSL_PARAM_BLD_push_BN(bld, "e", e)
+        || !OSSL_PARAM_BLD_push_uint(bld, "e", e)
         || (params = OSSL_PARAM_BLD_to_param(bld)) == NULL)
         goto err;
     OSSL_PARAM_BLD_free(bld);