From: Samuel Cabrero <scabrero@samba.org>
Date: Wed, 29 Nov 2023 11:55:13 +0000 (+0100)
Subject: idmap_nss: Increase debug on failures
X-Git-Tag: talloc-2.4.2~342
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c8e4777a921132082ee6421b2b456c82028fed46;p=thirdparty%2Fsamba.git

idmap_nss: Increase debug on failures

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
---

diff --git a/source3/winbindd/idmap_nss.c b/source3/winbindd/idmap_nss.c
index 642d5141784..8d2b23b4165 100644
--- a/source3/winbindd/idmap_nss.c
+++ b/source3/winbindd/idmap_nss.c
@@ -62,24 +62,36 @@ static NTSTATUS idmap_nss_unixids_to_sids(struct idmap_domain *dom, struct id_ma
 
 		switch (ids[i]->xid.type) {
 		case ID_TYPE_UID:
+			errno = 0;
 			pw = getpwuid((uid_t)ids[i]->xid.id);
-
 			if (!pw) {
+				DBG_DEBUG("getpwuid(%lu) failed: %s\n",
+					  (unsigned long)ids[i]->xid.id,
+					  errno != 0
+					  ? strerror(errno)
+					  : "not found");
 				ids[i]->status = ID_UNMAPPED;
 				continue;
 			}
 			name = pw->pw_name;
 			break;
 		case ID_TYPE_GID:
+			errno = 0;
 			gr = getgrgid((gid_t)ids[i]->xid.id);
-
 			if (!gr) {
+				DBG_DEBUG("getgrgid(%lu) failed: %s\n",
+					  (unsigned long)ids[i]->xid.id,
+					  errno != 0
+					  ? strerror(errno)
+					  : "not found");
 				ids[i]->status = ID_UNMAPPED;
 				continue;
 			}
 			name = gr->gr_name;
 			break;
 		default: /* ?? */
+			DBG_WARNING("Unexpected xid type %d\n",
+				    ids[i]->xid.type);
 			ids[i]->status = ID_UNKNOWN;
 			continue;
 		}