From: Andrew Bartlett Date: Thu, 3 May 2012 22:47:29 +0000 (+1000) Subject: s4-dsdb: Use data_blob_string_const and add explaination for open-coded function... X-Git-Tag: samba-4.0.0alpha21~376 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c8e6d8b4875e7dc67734597b6db8e81806d94faa;p=thirdparty%2Fsamba.git s4-dsdb: Use data_blob_string_const and add explaination for open-coded function in samldb Autobuild-User: Andrew Bartlett Autobuild-Date: Fri May 4 02:34:41 CEST 2012 on sn-devel-104 --- diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c b/source4/dsdb/samdb/ldb_modules/samldb.c index 7db7ff0f04c..41c97bf32a4 100644 --- a/source4/dsdb/samdb/ldb_modules/samldb.c +++ b/source4/dsdb/samdb/ldb_modules/samldb.c @@ -2018,8 +2018,11 @@ static int samldb_service_principal_names_change(struct samldb_ctx *ac) } /* - * append the new "servicePrincipalName" - code derived - * from ldb_msg_add_value() + * append the new "servicePrincipalName" - + * code derived from ldb_msg_add_value(). + * + * Open coded to make it clear that we must + * append to the MOD_REPLACE el created above. */ vals = talloc_realloc(ac->msg, el->values, struct ldb_val, @@ -2028,8 +2031,7 @@ static int samldb_service_principal_names_change(struct samldb_ctx *ac) return ldb_module_oom(ac->module); } el->values = vals; - el->values[el->num_values].data = (uint8_t *) new_str; - el->values[el->num_values].length = strlen(new_str); + el->values[el->num_values] = data_blob_string_const(new_str); ++(el->num_values); } }