From: Volker Lendecke <vl@samba.org>
Date: Thu, 22 Apr 2021 08:29:24 +0000 (+0200)
Subject: auth3: talloc_strackframe() panics on failure
X-Git-Tag: tevent-0.11.0~1019
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c9508b971ca54d5293d8976190635c406bd209c6;p=thirdparty%2Fsamba.git

auth3: talloc_strackframe() panics on failure

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Apr 27 14:14:22 UTC 2021 on sn-devel-184
---

diff --git a/source3/auth/server_info_sam.c b/source3/auth/server_info_sam.c
index 755791c1be4..79a7af7281e 100644
--- a/source3/auth/server_info_sam.c
+++ b/source3/auth/server_info_sam.c
@@ -65,14 +65,9 @@ NTSTATUS make_server_info_sam(TALLOC_CTX *mem_ctx,
 	struct passwd *pwd;
 	struct auth_serversupplied_info *server_info;
 	const char *username = pdb_get_username(sampass);
-	TALLOC_CTX *tmp_ctx;
+	TALLOC_CTX *tmp_ctx = talloc_stackframe();
 	NTSTATUS status;
 
-	tmp_ctx = talloc_stackframe();
-	if (tmp_ctx == NULL) {
-		return NT_STATUS_NO_MEMORY;
-	}
-
 	server_info = make_server_info(tmp_ctx);
 	if (server_info == NULL) {
 		status = NT_STATUS_NO_MEMORY;