From: Julien Palard <julien@palard.fr>
Date: Wed, 25 Nov 2020 09:18:00 +0000 (+0100)
Subject: bpo-42238: Doc: Remove make suspicious from the CI and docs builds. (GH-23313)
X-Git-Tag: v3.10.0a3~91
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c9c6e9f89aa68ce8094393a1a5575b67d26bc8c8;p=thirdparty%2FPython%2Fcpython.git

bpo-42238: Doc: Remove make suspicious from the CI and docs builds. (GH-23313)

It probably helped a lot a while back, but may not be as usefull
today.  We'll continue monitoring it before deletion, so true
positives can be migrated to rstlint.
---

diff --git a/.azure-pipelines/docs-steps.yml b/.azure-pipelines/docs-steps.yml
index eaf4ad01927a..55c38611b95c 100644
--- a/.azure-pipelines/docs-steps.yml
+++ b/.azure-pipelines/docs-steps.yml
@@ -16,7 +16,7 @@ steps:
   displayName: 'Install build dependencies'
 
 - ${{ if ne(parameters.latex, 'true') }}:
-  - script: make check suspicious html PYTHON=python
+  - script: make check html PYTHON=python
     workingDirectory: '$(build.sourcesDirectory)/Doc'
     displayName: 'Build documentation'
 
diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml
index 7c6012eed4f2..f0dbfcd9d3b4 100644
--- a/.github/workflows/doc.yml
+++ b/.github/workflows/doc.yml
@@ -36,7 +36,7 @@ jobs:
     - name: 'Install build dependencies'
       run: make -C Doc/ PYTHON=../python venv
     - name: 'Build documentation'
-      run: xvfb-run make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W --keep-going -j4" doctest suspicious html
+      run: xvfb-run make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W --keep-going -j4" doctest html
     - name: 'Upload'
       uses: actions/upload-artifact@v2.2.0
       with:
diff --git a/.travis.yml b/.travis.yml
index 254a4ea35ab9..dfdf670bff5f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -53,7 +53,7 @@ matrix:
         - cd Doc
         - make venv PYTHON=python
       script:
-        - make check suspicious html SPHINXOPTS="-q -W -j4"
+        - make check html SPHINXOPTS="-q -W -j4"
     - name: "Documentation tests"
       os: linux
       language: c
diff --git a/Doc/Makefile b/Doc/Makefile
index 6bf1f408b56f..c24c70c699a0 100644
--- a/Doc/Makefile
+++ b/Doc/Makefile
@@ -216,7 +216,6 @@ serve:
 # for development releases: always build
 autobuild-dev:
 	make dist SPHINXOPTS='$(SPHINXOPTS) -Ea -A daily=1'
-	-make suspicious
 
 # for quick rebuilds (HTML only)
 autobuild-dev-html:
diff --git a/Misc/NEWS.d/next/Documentation/2020-11-24-22-54-49.bpo-42238.62EOTu.rst b/Misc/NEWS.d/next/Documentation/2020-11-24-22-54-49.bpo-42238.62EOTu.rst
new file mode 100644
index 000000000000..d9edf9cdf79b
--- /dev/null
+++ b/Misc/NEWS.d/next/Documentation/2020-11-24-22-54-49.bpo-42238.62EOTu.rst
@@ -0,0 +1,2 @@
+Tentative to deprecate ``make suspicious`` by first removing it from the CI
+and documentation builds, but keeping it around for manual uses.