From: Pavel Filipenský Date: Wed, 3 Jul 2024 15:55:31 +0000 (+0200) Subject: s3:rpc_server: Initialize array struct security_ace ace[] X-Git-Tag: tdb-1.4.11~181 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=c9c74d819a2749e56626144714a555948149754c;p=thirdparty%2Fsamba.git s3:rpc_server: Initialize array struct security_ace ace[] Error: UNINIT (CWE-457): samba-4.20.0rc2/source4/torture/smb2/lease.c:567: var_decl: Declaring variable "h" without initializer. samba-4.20.0rc2/source4/torture/smb2/lease.c:642: uninit_use_in_call: Using uninitialized value "h" when calling "smb2_util_close". 640| 641| done: 642|-> smb2_util_close(tree, h); 643| smb2_util_close(tree, h2); 644| Signed-off-by: Pavel Filipenský Reviewed-by: Volker Lendecke Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Fri Jul 5 08:53:08 UTC 2024 on atb-devel-224 --- diff --git a/source3/rpc_server/lsa/srv_lsa_nt.c b/source3/rpc_server/lsa/srv_lsa_nt.c index 8bd2914538b..bf8ad241a5b 100644 --- a/source3/rpc_server/lsa/srv_lsa_nt.c +++ b/source3/rpc_server/lsa/srv_lsa_nt.c @@ -301,7 +301,7 @@ static NTSTATUS make_lsa_object_sd(TALLOC_CTX *mem_ctx, struct security_descript struct dom_sid *sid, uint32_t sid_access) { struct dom_sid adm_sid; - struct security_ace ace[5]; + struct security_ace ace[5] = {}; size_t i = 0; struct security_acl *psa = NULL;