From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Thu, 21 May 2020 10:44:21 +0000 (+0300)
Subject: lib-smtp: smtp_xtext_parse() - Remove unnecessary NULL check
X-Git-Tag: 2.3.13~732
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cab34492c2d681d59b2da30d0ca06431d2137c26;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: smtp_xtext_parse() - Remove unnecessary NULL check
---

diff --git a/src/lib-smtp/smtp-syntax.c b/src/lib-smtp/smtp-syntax.c
index 214df59fea..b542243fed 100644
--- a/src/lib-smtp/smtp-syntax.c
+++ b/src/lib-smtp/smtp-syntax.c
@@ -107,12 +107,10 @@ int smtp_xtext_parse(const char *xtext, const char **value_r,
 		return -1;
 	}
 
-	if (value_r != NULL) {
-		*value_r = str_c(value);
-		if (strlen(*value_r) != str_len(value)) {
-			*error_r = "Encountered NUL character in xtext";
-			return -1;
-		}
+	*value_r = str_c(value);
+	if (strlen(*value_r) != str_len(value)) {
+		*error_r = "Encountered NUL character in xtext";
+		return -1;
 	}
 	return 1;
 }