From: Volker Lendecke <vl@samba.org>
Date: Wed, 3 Jul 2019 11:44:59 +0000 (+0200)
Subject: smbd: Simplify smbd_smb2_setinfo_send()
X-Git-Tag: samba-4.11.0rc1~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cb2e6226fe666c9dc0b1e36411341db729b19d02;p=thirdparty%2Fsamba.git

smbd: Simplify smbd_smb2_setinfo_send()

Avoid an "else" branch

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/smbd/smb2_setinfo.c b/source3/smbd/smb2_setinfo.c
index 845c51d2930..82abd9c9d2e 100644
--- a/source3/smbd/smb2_setinfo.c
+++ b/source3/smbd/smb2_setinfo.c
@@ -443,11 +443,9 @@ static struct tevent_req *smbd_smb2_setinfo_send(TALLOC_CTX *mem_ctx,
 
 				tevent_req_done(req);
 				return tevent_req_post(req, ev);
-			} else {
-				tevent_req_nterror(req,
-					NT_STATUS_OBJECT_PATH_INVALID);
-				return tevent_req_post(req, ev);
 			}
+			tevent_req_nterror(req, NT_STATUS_OBJECT_PATH_INVALID);
+			return tevent_req_post(req, ev);
 		} else {
 			/*
 			 * Original code - this is an open file.