From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sat, 11 Feb 2017 18:22:13 +0000 (-0500)
Subject: basic/env-util: use _cleanup_ in replace_env()
X-Git-Tag: v233~59^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cb4499d0056a7c974d7d3695cc355c7e77edc938;p=thirdparty%2Fsystemd.git

basic/env-util: use _cleanup_ in replace_env()
---

diff --git a/src/basic/env-util.c b/src/basic/env-util.c
index 99a130008bd..8774a815311 100644
--- a/src/basic/env-util.c
+++ b/src/basic/env-util.c
@@ -527,7 +527,8 @@ char *replace_env(const char *format, char **env, unsigned flags) {
         } state = WORD;
 
         const char *e, *word = format;
-        char *r = NULL, *k;
+        char *k;
+        _cleanup_free_ char *r = NULL;
 
         assert(format);
 
@@ -544,7 +545,7 @@ char *replace_env(const char *format, char **env, unsigned flags) {
                         if (*e == '{') {
                                 k = strnappend(r, word, e-word-1);
                                 if (!k)
-                                        goto fail;
+                                        return NULL;
 
                                 free(r);
                                 r = k;
@@ -555,7 +556,7 @@ char *replace_env(const char *format, char **env, unsigned flags) {
                         } else if (*e == '$') {
                                 k = strnappend(r, word, e-word);
                                 if (!k)
-                                        goto fail;
+                                        return NULL;
 
                                 free(r);
                                 r = k;
@@ -574,7 +575,7 @@ char *replace_env(const char *format, char **env, unsigned flags) {
 
                                 k = strappend(r, t);
                                 if (!k)
-                                        goto fail;
+                                        return NULL;
 
                                 free(r);
                                 r = k;
@@ -586,15 +587,7 @@ char *replace_env(const char *format, char **env, unsigned flags) {
                 }
         }
 
-        k = strnappend(r, word, e-word);
-        if (!k)
-                goto fail;
-
-        free(r);
-        return k;
-
-fail:
-        return mfree(r);
+        return strnappend(r, word, e-word);
 }
 
 char **replace_env_argv(char **argv, char **env) {