From: W.C.A. Wijngaards Date: Wed, 17 Jun 2026 13:23:25 +0000 (+0200) Subject: - Fix that malloc failure in dns64_inform_super does X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cb5683aeae2f01032ac309bcff1ce5318d1c859d;p=thirdparty%2Funbound.git - Fix that malloc failure in dns64_inform_super does not set up a half-built reply for cache store, that could lead to a crash. Thanks to Qifan Zhang, Palo Alto Networks, for the report. --- diff --git a/dns64/dns64.c b/dns64/dns64.c index ca39bd964..8f9dba82f 100644 --- a/dns64/dns64.c +++ b/dns64/dns64.c @@ -955,8 +955,10 @@ dns64_adjust_ptr(struct module_qstate* qstate, struct module_qstate* super) return; super->return_msg->qinfo = super->qinfo; if (!(super->return_msg->rep = reply_info_copy(qstate->return_msg->rep, - NULL, super->region))) + NULL, super->region))) { + super->return_msg = NULL; return; + } /* * Adjust the domain name of the answer RR set so that it matches the diff --git a/doc/Changelog b/doc/Changelog index dced5c76c..ce19e50a4 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -14,6 +14,10 @@ - Fix that unbound-control auth_zone_reload stops the server answering from the zone after a failure to read. Thanks to Qifan Zhang, Palo Alto Networks, for the report. + - Fix that malloc failure in dns64_inform_super does + not set up a half-built reply for cache store, that could + lead to a crash. Thanks to Qifan Zhang, Palo Alto Networks, + for the report. 16 June 2026: Wouter - Fix to disallow $INCLUDE for secondary zones. Start up