From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 8 May 2019 02:37:06 +0000 (+1200)
Subject: s4/dnsserver: delay return when trying to log (CID 1444976)
X-Git-Tag: tdb-1.4.1~116
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cb9fe0360beee81c47931b2b3acb1836d2542614;p=thirdparty%2Fsamba.git

s4/dnsserver: delay return when trying to log (CID 1444976)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/dns_server/dnsserver_common.c b/source4/dns_server/dnsserver_common.c
index 04d50577eb6..5e687f6848e 100644
--- a/source4/dns_server/dnsserver_common.c
+++ b/source4/dns_server/dnsserver_common.c
@@ -559,7 +559,7 @@ WERROR dns_common_wildcard_lookup(struct ldb_context *samdb,
 
 	name = ldb_dn_get_rdn_val(dn);
 	if (name == NULL) {
-		return DNS_ERR(NAME_ERROR);
+		werr = DNS_ERR(NAME_ERROR);
 		goto exit;
 	}
 
@@ -615,7 +615,6 @@ WERROR dns_common_wildcard_lookup(struct ldb_context *samdb,
 	werr = dns_common_extract(samdb, el, mem_ctx, records, num_records);
 	TALLOC_FREE(msg);
 	if (!W_ERROR_IS_OK(werr)) {
-		return werr;
 		goto exit;
 	}