From: Christof Schmitt <cs@samba.org>
Date: Thu, 26 Oct 2023 21:45:34 +0000 (-0700)
Subject: vfs_gpfs: Implement CAP_DAC_OVERRIDE for fstat
X-Git-Tag: talloc-2.4.2~811
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cbdc16a7cfa225d1cf9109fafe85e9d14729700e;p=thirdparty%2Fsamba.git

vfs_gpfs: Implement CAP_DAC_OVERRIDE for fstat

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15507

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
index 8f232b5b00d..570cf796749 100644
--- a/source3/modules/vfs_gpfs.c
+++ b/source3/modules/vfs_gpfs.c
@@ -1664,6 +1664,29 @@ static int vfs_gpfs_stat(struct vfs_handle_struct *handle,
 	return ret;
 }
 
+static int vfs_gpfs_fstat(struct vfs_handle_struct *handle,
+			  struct files_struct *fsp,
+			  SMB_STRUCT_STAT *sbuf)
+{
+	int ret;
+
+	ret = SMB_VFS_NEXT_FSTAT(handle, fsp, sbuf);
+	if (ret == -1 && errno == EACCES) {
+		bool fake_dctime =
+			lp_fake_directory_create_times(SNUM(handle->conn));
+
+		DBG_DEBUG("fstat for %s failed with EACCES. Trying with "
+			  "CAP_DAC_OVERRIDE.\n", fsp->fsp_name->base_name);
+		ret = fstatat_with_cap_dac_override(fsp_get_pathref_fd(fsp),
+						    "",
+						    sbuf,
+						    AT_EMPTY_PATH,
+						    fake_dctime);
+	}
+
+	return ret;
+}
+
 static int vfs_gpfs_lstat(struct vfs_handle_struct *handle,
 			  struct smb_filename *smb_fname)
 {
@@ -2612,6 +2635,7 @@ static struct vfs_fn_pointers vfs_gpfs_fns = {
 	.fchmod_fn = vfs_gpfs_fchmod,
 	.close_fn = vfs_gpfs_close,
 	.stat_fn = vfs_gpfs_stat,
+	.fstat_fn = vfs_gpfs_fstat,
 	.lstat_fn = vfs_gpfs_lstat,
 	.fntimes_fn = vfs_gpfs_fntimes,
 	.aio_force_fn = vfs_gpfs_aio_force,