From: Topi Miettinen Date: Thu, 31 Jan 2019 17:07:06 +0000 (+0200) Subject: backlight: handle loading truncated file X-Git-Tag: v242-rc1~329^2~1 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cbed254f9673256836554b0b6e16941747f925f8;p=thirdparty%2Fsystemd.git backlight: handle loading truncated file I had accidentally filled my /var partition. This caused backlight to fail to start even with disk space, because the brightness files were truncated to zero size: systemd-backlight[624]: acpi_video0: Failed to parse brightness "": Invalid argument systemd-backlight[624]: acpi_video0: Failed to write system 'brightness' attribute: No such device or address systemd[1]: systemd-backlight@backlight:acpi_video0.service: Main process exited, code=exited, status=1/FAILURE systemd[1]: systemd-backlight@backlight:acpi_video0.service: Failed with result 'exit-code'. systemd[1]: Failed to start Load/Save Screen Backlight Brightness of backlight:acpi_video0. Handle a truncated file like non-existent file. --- diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c index 780ad56eb1d..2fcc693c48f 100644 --- a/src/backlight/backlight.c +++ b/src/backlight/backlight.c @@ -379,7 +379,7 @@ static int run(int argc, char *argv[]) { clamp = shall_clamp(device); r = read_one_line_file(saved, &value); - if (r == -ENOENT) { + if (IN_SET(r, -ENOENT, 0)) { const char *curval; /* Fallback to clamping current brightness or exit early if