From: Victor Stinner Date: Fri, 11 Jul 2025 14:45:31 +0000 (+0200) Subject: gh-136156: Remove tempfile test_link_tmpfile() (#136534) X-Git-Tag: v3.15.0a1~1012 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cbf007beeb2f69d9409b6388ee8d71007fa6c2df;p=thirdparty%2FPython%2Fcpython.git gh-136156: Remove tempfile test_link_tmpfile() (#136534) It's not always possible to guarantee that the file was opened with O_TMPFILE even if tempfile._O_TMPFILE_WORKS is true. --- diff --git a/Lib/test/test_tempfile.py b/Lib/test/test_tempfile.py index aeca62cf2564..52b13b98cbcc 100644 --- a/Lib/test/test_tempfile.py +++ b/Lib/test/test_tempfile.py @@ -1594,30 +1594,6 @@ if tempfile.NamedTemporaryFile is not tempfile.TemporaryFile: mock_close.assert_called() self.assertEqual(os.listdir(dir), []) - @os_helper.skip_unless_hardlink - @unittest.skipUnless(tempfile._O_TMPFILE_WORKS, 'need os.O_TMPFILE') - @unittest.skipUnless(os.path.exists('/proc/self/fd'), - 'need /proc/self/fd') - def test_link_tmpfile(self): - dir = tempfile.mkdtemp() - self.addCleanup(os_helper.rmtree, dir) - filename = os.path.join(dir, "link") - - with tempfile.TemporaryFile('w', dir=dir) as tmp: - # the flag can become False on Linux <= 3.11 - if not tempfile._O_TMPFILE_WORKS: - self.skipTest("O_TMPFILE doesn't work") - - tmp.write("hello") - tmp.flush() - fd = tmp.fileno() - - os.link(f'/proc/self/fd/{fd}', - filename, - follow_symlinks=True) - with open(filename) as fp: - self.assertEqual(fp.read(), "hello") - # Helper for test_del_on_shutdown class NulledModules: