From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 20 Oct 2023 23:56:54 +0000 (+1300)
Subject: libcli/security: sddl: check a talloc_zero
X-Git-Tag: talloc-2.4.2~907
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cc11165ecbcb1f51f853ffe8b1ab9ec338bfb4d0;p=thirdparty%2Fsamba.git

libcli/security: sddl: check a talloc_zero

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index e973a091005..04cc577d2c8 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -827,7 +827,9 @@ struct security_descriptor *sddl_decode(TALLOC_CTX *mem_ctx, const char *sddl,
 	};
 	struct security_descriptor *sd;
 	sd = talloc_zero(mem_ctx, struct security_descriptor);
-
+	if (sd == NULL) {
+		goto failed;
+	}
 	sd->revision = SECURITY_DESCRIPTOR_REVISION_1;
 	sd->type     = SEC_DESC_SELF_RELATIVE;