From: Ralf Habacker Date: Wed, 6 May 2015 06:25:20 +0000 (+0200) Subject: dbus_message_demarshal: Fix calling _dbus_string_append_len without checking return... X-Git-Tag: dbus-1.8.18~6 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cc4c2d72bcc599f8994d19b7ad409b596474ea2b;p=thirdparty%2Fdbus.git dbus_message_demarshal: Fix calling _dbus_string_append_len without checking return value (CID 54690). Reported by Coverity: CID 54690: Unchecked return value (CHECKED_RETURN) Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021 Reviewed-by: Simon McVittie --- diff --git a/dbus/dbus-message.c b/dbus/dbus-message.c index 3e74fc54e..1f433712c 100644 --- a/dbus/dbus-message.c +++ b/dbus/dbus-message.c @@ -4796,7 +4796,10 @@ dbus_message_demarshal (const char *str, return NULL; _dbus_message_loader_get_buffer (loader, &buffer); - _dbus_string_append_len (buffer, str, len); + + if (!_dbus_string_append_len (buffer, str, len)) + goto fail_oom; + _dbus_message_loader_return_buffer (loader, buffer); if (!_dbus_message_loader_queue_messages (loader))