From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 17 Jul 2024 15:54:09 +0000 (+0200)
Subject: env-util: suppress unnecessary setenv() in setenvf()
X-Git-Tag: v257-rc1~873^2~45
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cc915eefafa89fe49da3afaf0f3fdaef24679b62;p=thirdparty%2Fsystemd.git

env-util: suppress unnecessary setenv() in setenvf()
---

diff --git a/src/basic/env-util.c b/src/basic/env-util.c
index 3e385e5ee4b..cf2c47d2142 100644
--- a/src/basic/env-util.c
+++ b/src/basic/env-util.c
@@ -1146,5 +1146,10 @@ int setenvf(const char *name, bool overwrite, const char *valuef, ...) {
         if (r < 0)
                 return -ENOMEM;
 
+        /* Try to suppress writes if the value is already set correctly (simply because memory management of
+         * environment variables sucks a bit. */
+        if (streq_ptr(getenv(name), value))
+                return 0;
+
         return RET_NERRNO(setenv(name, value, overwrite));
 }