From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 19 Sep 2019 07:54:12 +0000 (+0200)
Subject: http_proxy: part of conditional expression is always true: !error
X-Git-Tag: curl-7_67_0~163
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cc95dbd64f35bc11c55c475d32012c5491e2f01b;p=thirdparty%2Fcurl.git

http_proxy: part of conditional expression is always true: !error

Fixes warning detected by PVS-Studio
Fixes #4374
---

diff --git a/lib/http_proxy.c b/lib/http_proxy.c
index ba67b861bd..710101774a 100644
--- a/lib/http_proxy.c
+++ b/lib/http_proxy.c
@@ -327,7 +327,7 @@ static CURLcode CONNECT(struct connectdata *conn,
     { /* READING RESPONSE PHASE */
       int error = SELECT_OK;
 
-      while(s->keepon && !error) {
+      while(s->keepon) {
         ssize_t gotbytes;
 
         /* make sure we have space to read more data */