From: Barry Warsaw <barry@python.org>
Date: Wed, 11 Sep 2002 02:56:42 +0000 (+0000)
Subject: test_both(): I believe this was a typo: m is only defined if no
X-Git-Tag: v2.3c1~4139
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ccd9e75b189c8084b08af797c5711938685b8b5b;p=thirdparty%2FPython%2Fcpython.git

test_both(): I believe this was a typo: m is only defined if no
exception occurred so it should only be closed in the else clause.
Without this change we can an UnboundLocalError on Linux:

Traceback (most recent call last):
  File "Lib/test/test_mmap.py", line 304, in ?
    test_both()
  File "Lib/test/test_mmap.py", line 208, in test_both
    m.close()
UnboundLocalError: local variable 'm' referenced before assignment
---

diff --git a/Lib/test/test_mmap.py b/Lib/test/test_mmap.py
index ea9c4eed4c68..417080f0055e 100644
--- a/Lib/test/test_mmap.py
+++ b/Lib/test/test_mmap.py
@@ -205,7 +205,7 @@ def test_both():
             # we expect a ValueError on Unix, but not on Windows
             if not sys.platform.startswith('win'):
                 verify(0, "Opening mmap with size+1 should raise ValueError.")
-        m.close()
+            m.close()
         f.close()
         if sys.platform.startswith('win'):
             # Repair damage from the resizing test.