From: Mukund Sivaraman <muks@isc.org>
Date: Thu, 13 Sep 2012 09:52:22 +0000 (+0530)
Subject: [master] Remove redundant NULL checks in PySerial
X-Git-Tag: trac2351_base~47^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ccdbcf02d9f4a2bbd69475428b86458c1ee6334a;p=thirdparty%2Fkea.git

[master] Remove redundant NULL checks in PySerial

These are not required according to:
http://docs.python.org/py3k/extending/extending.html?highlight=null#null-pointers

These NULL checks cause static analysis reports in other parts of the
code where the pointers are not NULL tested before use.
---

diff --git a/src/lib/dns/python/serial_python.cc b/src/lib/dns/python/serial_python.cc
index e2bd809219..f4f4720df5 100644
--- a/src/lib/dns/python/serial_python.cc
+++ b/src/lib/dns/python/serial_python.cc
@@ -259,19 +259,11 @@ createSerialObject(const Serial& source) {
 
 bool
 PySerial_Check(PyObject* obj) {
-    if (obj == NULL) {
-        isc_throw(PyCPPWrapperException,
-                  "obj argument NULL in Serial typecheck");
-    }
     return (PyObject_TypeCheck(obj, &serial_type));
 }
 
 const Serial&
 PySerial_ToSerial(const PyObject* serial_obj) {
-    if (serial_obj == NULL) {
-        isc_throw(PyCPPWrapperException,
-                  "obj argument NULL in Serial PyObject conversion");
-    }
     const s_Serial* serial = static_cast<const s_Serial*>(serial_obj);
     return (*serial->cppobj);
 }