From: Ralf Lici Date: Wed, 1 Jul 2026 07:41:15 +0000 (+0200) Subject: dco.c: fix argument order in dco_install_key() log string X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cda2f2533c27f37cfe7a741c9e042a54740e377f;p=thirdparty%2Fopenvpn.git dco.c: fix argument order in dco_install_key() log string The debug log in dco_install_key() has the epoch and dco_keys_installed arguments swapped. So a line like epoch=1, currently 0 keys installed actually means dco_keys_installed == 1 and epoch == false. Use the correct argument ordering in the log string. Change-Id: Id8945dce437da11e6fecae9550c3be52e393d4cf Signed-off-by: Ralf Lici Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1760 Message-Id: <20260701074122.28795-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37418.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index f5b70818b..e944547b9 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -57,8 +57,8 @@ dco_install_key(struct tls_multi *multi, struct key_state *ks, const uint8_t *en { bool epoch = ks->crypto_options.flags & CO_EPOCH_DATA_KEY_FORMAT; - msg(D_DCO_DEBUG, "%s: peer_id=%d keyid=%d epoch=%d, currently %d keys installed", __func__, - multi->dco_peer_id, ks->key_id, multi->dco_keys_installed, epoch); + msg(D_DCO_DEBUG, "%s: peer_id=%d keyid=%d epoch=%d, currently %d keys installed", + __func__, multi->dco_peer_id, ks->key_id, epoch, multi->dco_keys_installed); /* Install a key in the PRIMARY slot only when no other key exist. * From that moment on, any new key will be installed in the SECONDARY