From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 10 Jul 2018 21:18:20 +0000 (-0400)
Subject: Stupid OpenSSL grr
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cde6436104a43f211774fc6cc686ecb7d84da16a;p=thirdparty%2Ffreeradius-server.git

Stupid OpenSSL grr
---

diff --git a/src/lib/tls/session.c b/src/lib/tls/session.c
index c2a0a83cb28..82bdb57f60b 100644
--- a/src/lib/tls/session.c
+++ b/src/lib/tls/session.c
@@ -879,8 +879,6 @@ int tls_session_pairs_from_x509_cert(fr_cursor_t *cursor, TALLOC_CTX *ctx,
 	char		buffer[1024];
 	char		attribute[256];
 	char		**identity;
-	char		*subject;
-
 	int		attr_index, loc;
 
 #if OPENSSL_VERSION_NUMBER >= 0x10100000L
@@ -906,8 +904,12 @@ int tls_session_pairs_from_x509_cert(fr_cursor_t *cursor, TALLOC_CTX *ctx,
 
 	identity = (char **)SSL_get_ex_data(session->ssl, FR_TLS_EX_INDEX_IDENTITY);
 
-	subject = X509_get_subject_name(cert);
-	RDEBUG2("Creating attributes for \"%s\":", subject ? : subject : "Cert missing subject OID");
+	if (RDEBUG_ENABLED2) {
+		buffer[0] = '\0';
+		X509_NAME_oneline(X509_get_subject_name(cert), buffer, sizeof(buffer));
+		buffer[sizeof(buffer) - 1] = '\0';
+		RDEBUG2("Creating attributes for \"%s\":", buffer[0] ? buffer : "Cert missing subject OID");
+	}
 
 	/*
 	 *	Get the Serial Number