From: Brett Cannon <bcannon@gmail.com>
Date: Fri, 5 Sep 2008 22:59:17 +0000 (+0000)
Subject: GNU coding guidelines say that ``make check`` should verify the build. That
X-Git-Tag: v2.6rc1~49
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cdeb24bb05359ec7550c327f44e8b1f346b9d776;p=thirdparty%2FPython%2Fcpython.git

GNU coding guidelines say that ``make check`` should verify the build. That
clashes with what Python's build target did. Rename the target to 'patchcheck'
to avoid the culture clash.

Closes issue 3758.
Reviewed by Benjamin Peterson.
---

diff --git a/Makefile.pre.in b/Makefile.pre.in
index 349b81481845..8451445fefba 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -1190,7 +1190,7 @@ funny:
 		-o -print
 
 # Perform some verification checks on any modified files.
-check:
+patchcheck:
 	$(RUNSHARED) ./$(BUILDPYTHON) $(srcdir)/Tools/scripts/patchcheck.py
 
 # Dependencies
diff --git a/Misc/NEWS b/Misc/NEWS
index 8c246538a827..1ab858191889 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -112,6 +112,12 @@ Tests
 
 - Issue 3768: Move test_py3kwarn over to the new API for catch_warnings().
 
+Build
+-----
+
+- Issue 3758: Rename the 'check' target to 'patchcheck' so as to not clash with
+  GNU build target guidelines.
+
 
 What's New in Python 2.6 beta 3?
 ================================