From: Martin Schwenke <martin@meltin.net>
Date: Wed, 21 Mar 2018 05:37:57 +0000 (+1100)
Subject: ctdb-tests: Remove case statement in ctdb stub
X-Git-Tag: talloc-2.1.13~195
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ce1b5b30d3badd2dac3ff4df67e60eb3f3c6bbbc;p=thirdparty%2Fsamba.git

ctdb-tests: Remove case statement in ctdb stub

This removes a lot of unnecessary clutter.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/tests/eventscripts/stubs/ctdb b/ctdb/tests/eventscripts/stubs/ctdb
index 1090543eb36..b4965289a01 100755
--- a/ctdb/tests/eventscripts/stubs/ctdb
+++ b/ctdb/tests/eventscripts/stubs/ctdb
@@ -469,26 +469,17 @@ ctdb_gratarp ()
 
 ######################################################################
 
-case "$1" in
-    gettickles) shift ; ctdb_gettickles "$@" ;;
-    addtickle) shift ; ctdb_addtickle "$@" ;;
-    deltickle) shift ; ctdb_deltickle "$@" ;;
-    pstore) shift; ctdb_pstore  "$@" ;;
-    pdelete) shift ; ctdb_pdelete "$@" ;;
-    pfetch) shift ; ctdb_pfetch  "$@" ;;
-    ptrans) shift ; ctdb_ptrans  "$@" ;;
-    catdb) shift ; ctdb_catdb   "$@" ;;
-    ifaces) shift ; ctdb_ifaces "$@" ;;
-    setifacelink) shift ; ctdb_setifacelink "$@" ;;
-    checktcpport) shift ; ctdb_checktcpport "$@" ;;
-    gratarp) shift ; ctdb_gratarp "$@" ;;
-    ip) shift ; ctdb_ip "$@" ;;
-    pnn) shift ; ctdb_pnn ;;
-    enable) shift ; ctdb_enable "$@";;
-    disable) shift ; ctdb_disable "$@";;
-    moveip) shift ; ctdb_moveip "$@";;
-    shutdown) shift ; ctdb_shutdown "$@";;
-    setvar) shift ; ctdb_setvar "$@" ;;
-    nodestatus) shift ; ctdb_nodestatus "$@" ;;
-    *) not_implemented "$1" ;;
-esac
+cmd="$1"
+shift
+
+func="ctdb_${cmd}"
+
+# This could inadvertently run an external function instead of a local
+# function.  However, this can only happen if testing a script
+# containing a new ctdb command that is not implemented, so this is
+# unlikely to do harm.
+if type "$func" >/dev/null 2>&1 ; then
+	"$func" "$@"
+else
+	not_implemented "$cmd"
+fi