From: Colin Walters <walters@verbum.org>
Date: Mon, 15 Mar 2010 22:31:30 +0000 (-0400)
Subject: Make SELinux initialization failure fatal
X-Git-Tag: dbus-1.2.22~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ce34415302af586ea6ca9b0da4b21a7025041ef7;p=thirdparty%2Fdbus.git

Make SELinux initialization failure fatal

https://bugzilla.redhat.com/show_bug.cgi?id=572769

Previously we'd just continue if AVC initialization failed, but
that didn't really work because then we'd later crash in
avc_has_perm.

Simply treat initialization failures as fatal, and hopefully we
can get data from the system log.
---

diff --git a/bus/bus.c b/bus/bus.c
index aaca3aa0d..3e37e90a2 100644
--- a/bus/bus.c
+++ b/bus/bus.c
@@ -803,9 +803,9 @@ bus_context_new (const DBusString *config_file,
 
   if (!bus_selinux_full_init ())
     {
-      _dbus_warn ("SELinux initialization failed\n");
+      bus_context_log (context, DBUS_SYSTEM_LOG_FATAL, "SELinux enabled but AVC initialization failed; check system log\n");
     }
-  
+
   if (!process_config_postinit (context, parser, error))
     {
       _DBUS_ASSERT_ERROR_IS_SET (error);