From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 10 Dec 2015 14:03:47 +0000 (-0500)
Subject: improve a comment in memwipe
X-Git-Tag: tor-0.2.8.1-alpha~166
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ce3b7ddb5494d51868bbaa1922f9bdb192907527;p=thirdparty%2Ftor.git

improve a comment in memwipe
---

diff --git a/src/common/crypto.c b/src/common/crypto.c
index 816423aa85..ba5c8a79b5 100644
--- a/src/common/crypto.c
+++ b/src/common/crypto.c
@@ -2817,7 +2817,11 @@ memwipe(void *mem, uint8_t byte, size_t sz)
    * variable.  It's an elaborate ruse to trick the compiler into not
    * optimizing out the "wipe this memory" code.  Read it if you like zany
    * programming tricks! In later versions of Tor, we should look for better
-   * not-optimized-out memory wiping stuff. */
+   * not-optimized-out memory wiping stuff...
+   *
+   * ...or maybe not.  In practice, there are pure-asm implementations of
+   * OPENSSL_cleanse() on most platforms, which ought to do the job.
+   **/
   OPENSSL_cleanse(mem, sz);
   /* Just in case some caller of memwipe() is relying on getting a buffer
    * filled with a particular value, fill the buffer.