From: INADA Naoki Date: Mon, 20 Feb 2017 13:58:11 +0000 (+0900) Subject: bpo-24274: fix erroneous comment in dictobject.c (GH-200) X-Git-Tag: v3.6.1rc1~68 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ce552e2d5c4ff90218fb41847e8ffb1fd3ba3b2d;p=thirdparty%2FPython%2Fcpython.git bpo-24274: fix erroneous comment in dictobject.c (GH-200) lookdict_unicode() and lookdict_unicode_nodummy() may raise exception when key is not unicode. --- diff --git a/Objects/dictobject.c b/Objects/dictobject.c index b63b78a33722..a0c1977037b9 100644 --- a/Objects/dictobject.c +++ b/Objects/dictobject.c @@ -676,7 +676,8 @@ Christian Tismer. lookdict() is general-purpose, and may return DKIX_ERROR if (and only if) a comparison raises an exception. lookdict_unicode() below is specialized to string keys, comparison of which can -never raise an exception; that function can never return DKIX_ERROR. +never raise an exception; that function can never return DKIX_ERROR when key +is string. Otherwise, it falls back to lookdict(). lookdict_unicode_nodummy is further specialized for string keys that cannot be the value. For both, when the key isn't found a DKIX_EMPTY is returned. hashpos returns