From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Sun, 12 Nov 2023 23:56:13 +0000 (+1300)
Subject: libcli/security/sddl: improve some SDDL error messages
X-Git-Tag: talloc-2.4.2~512
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cea44421ebc1242485dbf614e891c1786a800594;p=thirdparty%2Fsamba.git

libcli/security/sddl: improve some SDDL error messages

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index a4659c107b5..1f2ac644f67 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -731,7 +731,8 @@ static bool sddl_decode_ace(TALLOC_CTX *mem_ctx,
 		if (s[length] != ')') {
 			*msg = talloc_strdup(
 				mem_ctx,
-				"Conditional ACE has trailing bytes");
+				"Conditional ACE has trailing bytes"
+				" or lacks ')'");
 			*msg_offset = s + length - *sddl_copy;
 			return false;
 		}
@@ -767,7 +768,8 @@ static bool sddl_decode_ace(TALLOC_CTX *mem_ctx,
 		if (s[length] != ')') {
 			*msg = talloc_strdup(
 				mem_ctx,
-				"Resource Attribute ACE has trailing bytes");
+				"Resource Attribute ACE has trailing bytes"
+				" or lacks ')'");
 			*msg_offset = s + length - *sddl_copy;
 			return false;
 		}