From: Sean Bright Date: Tue, 30 Apr 2013 13:45:40 +0000 (+0000) Subject: Use the proper lower bound when doing saturation arithmetic. X-Git-Tag: 1.8.23.0-rc1~34 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cf90e44d998837e1e485f5373ce33e3bd9e46209;p=thirdparty%2Fasterisk.git Use the proper lower bound when doing saturation arithmetic. 16 bit signed integers have a range of [-32768, 32768). The existing code was using the interval (-32768, 32768) instead. This patch fixes that. Review: https://reviewboard.asterisk.org/r/2479/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@386929 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/include/asterisk/utils.h b/include/asterisk/utils.h index aa927cc361..415e396730 100644 --- a/include/asterisk/utils.h +++ b/include/asterisk/utils.h @@ -307,8 +307,8 @@ static force_inline void ast_slinear_saturated_add(short *input, short *value) res = (int) *input + *value; if (res > 32767) *input = 32767; - else if (res < -32767) - *input = -32767; + else if (res < -32768) + *input = -32768; else *input = (short) res; } @@ -320,8 +320,8 @@ static force_inline void ast_slinear_saturated_subtract(short *input, short *val res = (int) *input - *value; if (res > 32767) *input = 32767; - else if (res < -32767) - *input = -32767; + else if (res < -32768) + *input = -32768; else *input = (short) res; } @@ -333,8 +333,8 @@ static force_inline void ast_slinear_saturated_multiply(short *input, short *val res = (int) *input * *value; if (res > 32767) *input = 32767; - else if (res < -32767) - *input = -32767; + else if (res < -32768) + *input = -32768; else *input = (short) res; }