From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 9 Oct 2018 20:22:52 +0000 (+0200)
Subject: core: make destructive transaction error a bit more useful
X-Git-Tag: v240~549^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cf99f8eacf1c864b19a6a02edea78c43f3185cb7;p=thirdparty%2Fsystemd.git

core: make destructive transaction error a bit more useful
---

diff --git a/src/core/transaction.c b/src/core/transaction.c
index 045930838b1..486c6a4a05b 100644
--- a/src/core/transaction.c
+++ b/src/core/transaction.c
@@ -526,7 +526,9 @@ static int transaction_is_destructive(Transaction *tr, JobMode mode, sd_bus_erro
                 if (j->unit->job && (mode == JOB_FAIL || j->unit->job->irreversible) &&
                     job_type_is_conflicting(j->unit->job->type, j->type))
                         return sd_bus_error_setf(e, BUS_ERROR_TRANSACTION_IS_DESTRUCTIVE,
-                                                 "Transaction is destructive.");
+                                                 "Transaction for %s/%s is destructive (%s has '%s' job queued, but '%s' is included in transaction).",
+                                                 tr->anchor_job->unit->id, job_type_to_string(tr->anchor_job->type),
+                                                 j->unit->id, job_type_to_string(j->unit->job->type), job_type_to_string(j->type));
         }
 
         return 0;