From: zeeeeeb <5767468+zeeeeeb@users.noreply.github.com>
Date: Thu, 10 Feb 2022 04:33:51 +0000 (-0800)
Subject: fixes: #5465; incorporating feedback
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=cfaebeef5bd74851940a462f84711ae852f19cbd;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

fixes: #5465; incorporating feedback
---

diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py
index 6b01960d45..30976e2ce7 100644
--- a/lib/sqlalchemy/dialects/mssql/base.py
+++ b/lib/sqlalchemy/dialects/mssql/base.py
@@ -1488,8 +1488,6 @@ class MSTypeCompiler(compiler.GenericTypeCompiler):
         else:
             return "FLOAT(%(precision)s)" % {"precision": precision}
 
-    def visit_DOUBLE(self, type_, **kw):
-        return "FLOAT"
 
     def visit_TINYINT(self, type_, **kw):
         return "TINYINT"
diff --git a/lib/sqlalchemy/dialects/oracle/base.py b/lib/sqlalchemy/dialects/oracle/base.py
index c10f83cfac..496e573cc8 100644
--- a/lib/sqlalchemy/dialects/oracle/base.py
+++ b/lib/sqlalchemy/dialects/oracle/base.py
@@ -769,9 +769,6 @@ class OracleTypeCompiler(compiler.GenericTypeCompiler):
         else:
             return self.visit_VARCHAR2(type_, **kw)
 
-    def visit_DOUBLE(self, type_, **kw):
-        return self.visit_DOUBLE_PRECISION(type_, **kw)
-
     def visit_INTERVAL(self, type_, **kw):
         return "INTERVAL DAY%s TO SECOND%s" % (
             type_.day_precision is not None
diff --git a/lib/sqlalchemy/dialects/postgresql/base.py b/lib/sqlalchemy/dialects/postgresql/base.py
index 2d44932c0f..3a6788b65c 100644
--- a/lib/sqlalchemy/dialects/postgresql/base.py
+++ b/lib/sqlalchemy/dialects/postgresql/base.py
@@ -2899,11 +2899,8 @@ class PGTypeCompiler(compiler.GenericTypeCompiler):
     def visit_DOUBLE_PRECISION(self, type_, **kw):
         return "DOUBLE PRECISION"
 
-    def visit_DOUBLE(self, type_, **kw):
-        return "DOUBLE PRECISION"
-
     def visit_double(self, type_, **kw):
-        return "DOUBLE PRECISION"
+        return self.visit_DOUBLE_PRECISION(type, **kw)
 
     def visit_BIGINT(self, type_, **kw):
         return "BIGINT"
diff --git a/test/dialect/mssql/test_types.py b/test/dialect/mssql/test_types.py
index ba74a7970a..2ef8b76dae 100644
--- a/test/dialect/mssql/test_types.py
+++ b/test/dialect/mssql/test_types.py
@@ -295,8 +295,6 @@ class TypeDDLTest(fixtures.TestBase):
             (types.Float, [], {}, "FLOAT"),
             (types.Float, [None], {}, "FLOAT"),
             (types.Float, [12], {}, "FLOAT(12)"),
-            (types.Double, [], {}, "FLOAT"),
-            (types.DOUBLE, [], {}, "FLOAT"),
             (mssql.MSReal, [], {}, "REAL"),
             (types.Integer, [], {}, "INTEGER"),
             (types.BigInteger, [], {}, "BIGINT"),