From: Volker Lendecke <vl@samba.org>
Date: Thu, 28 Nov 2024 14:48:45 +0000 (+0100)
Subject: vfs: Simplify connect_acl_xattr()
X-Git-Tag: tdb-1.4.13~325
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d088738342a378cdd2469abd13d32c80a9233355;p=thirdparty%2Fsamba.git

vfs: Simplify connect_acl_xattr()

We don't need talloc for printing a mask with %o

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
---

diff --git a/source3/modules/vfs_acl_xattr.c b/source3/modules/vfs_acl_xattr.c
index 1a3ab34d659..7f7b9006570 100644
--- a/source3/modules/vfs_acl_xattr.c
+++ b/source3/modules/vfs_acl_xattr.c
@@ -218,23 +218,21 @@ static int connect_acl_xattr(struct vfs_handle_struct *handle,
 
 	if (config->ignore_system_acls) {
 		mode_t create_mask = lp_create_mask(SNUM(handle->conn));
-		char *create_mask_str = NULL;
 
 		if ((create_mask & 0666) != 0666) {
+			char create_mask_str[16];
+
 			create_mask |= 0666;
-			create_mask_str = talloc_asprintf(handle, "0%o",
-							  create_mask);
-			if (create_mask_str == NULL) {
-				DBG_ERR("talloc_asprintf failed\n");
-				return -1;
-			}
+			snprintf(create_mask_str,
+				 sizeof(create_mask_str),
+				 "0%o",
+				 create_mask);
 
 			DBG_NOTICE("setting 'create mask = %s'\n", create_mask_str);
 
-			lp_do_parameter (SNUM(handle->conn),
-					"create mask", create_mask_str);
-
-			TALLOC_FREE(create_mask_str);
+			lp_do_parameter(SNUM(handle->conn),
+					"create mask",
+					create_mask_str);
 		}
 
 		DBG_NOTICE("setting 'directory mask = 0777', "