From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 20 Feb 2020 22:44:47 +0000 (-0800)
Subject: bpo-39184: Fix incorrect return value (GH-18580)
X-Git-Tag: v3.8.2~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d0a464e31ac67685ef8ad35ecd993f17dfd6ab35;p=thirdparty%2FPython%2Fcpython.git

bpo-39184: Fix incorrect return value (GH-18580)


https://bugs.python.org/issue39184

Automerge-Triggered-By: @zooba
(cherry picked from commit 6c444d0dab8f06cf304263b34beb299101cef3de)

Co-authored-by: Steve Dower <steve.dower@python.org>
---

diff --git a/PC/msvcrtmodule.c b/PC/msvcrtmodule.c
index 5c06ec2621ea..faceb03fba39 100644
--- a/PC/msvcrtmodule.c
+++ b/PC/msvcrtmodule.c
@@ -180,7 +180,7 @@ msvcrt_open_osfhandle_impl(PyObject *module, void *handle, int flags)
     int fd;
 
     if (PySys_Audit("msvcrt.open_osfhandle", "Ki", handle, flags) < 0) {
-        return NULL;
+        return -1;
     }
 
     _Py_BEGIN_SUPPRESS_IPH