From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Fri, 16 Jun 2023 02:32:09 +0000 (+1200)
Subject: s4:kdc: Flip sense of condition
X-Git-Tag: talloc-2.4.1~200
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d0d52262f781b8acddc4f50e09e2daa1198b8a3e;p=thirdparty%2Fsamba.git

s4:kdc: Flip sense of condition

A negative condition incurs more cognitive load.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 7000e3a53e4..10d63848857 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -2493,7 +2493,26 @@ krb5_error_code samba_kdc_update_pac(TALLOC_CTX *mem_ctx,
 		goto done;
 	}
 
-	if (!client_pac_is_trusted) {
+	if (client_pac_is_trusted) {
+		pac_blob = talloc_zero(mem_ctx, DATA_BLOB);
+		if (pac_blob == NULL) {
+			code = ENOMEM;
+			goto done;
+		}
+
+		nt_status = samba_get_logon_info_pac_blob(mem_ctx,
+							  user_info_dc,
+							  _resource_groups,
+							  group_inclusion,
+							  pac_blob);
+		if (!NT_STATUS_IS_OK(nt_status)) {
+			DBG_ERR("samba_get_logon_info_pac_blob failed: %s\n",
+				nt_errstr(nt_status));
+
+			code = EINVAL;
+			goto done;
+		}
+	} else {
 		nt_status = samba_kdc_get_logon_info_blob(mem_ctx,
 						       user_info_dc,
 						       group_inclusion,
@@ -2535,25 +2554,6 @@ krb5_error_code samba_kdc_update_pac(TALLOC_CTX *mem_ctx,
 			code = EINVAL;
 			goto done;
 		}
-	} else {
-		pac_blob = talloc_zero(mem_ctx, DATA_BLOB);
-		if (pac_blob == NULL) {
-			code = ENOMEM;
-			goto done;
-		}
-
-		nt_status = samba_get_logon_info_pac_blob(mem_ctx,
-							  user_info_dc,
-							  _resource_groups,
-							  group_inclusion,
-							  pac_blob);
-		if (!NT_STATUS_IS_OK(nt_status)) {
-			DBG_ERR("samba_get_logon_info_pac_blob failed: %s\n",
-				nt_errstr(nt_status));
-
-			code = EINVAL;
-			goto done;
-		}
 	}
 
 	/* Check the types of the given PAC */